Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare support for Python 3.9 #2942

Merged
merged 2 commits into from
Sep 24, 2021
Merged

Declare support for Python 3.9 #2942

merged 2 commits into from
Sep 24, 2021

Conversation

D3X
Copy link
Contributor

@D3X D3X commented Jul 30, 2021

I ran the test suite locally and it succeeded:

TOTAL                            2302     46    98%
----------------------------------------------------------------------
Ran 1730 tests in 322.714s

OK
______________________________ summary _______________________________
  py39: commands succeeded
  congratulations :)

hugovk
hugovk approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps add 3.9 to the CI as well?

boto3/.github/workflows/run-tests.yml

Line 16 in 267cd97

python-version: [3.6, 3.7, 3.8]

@D3X
Copy link
Contributor Author

D3X commented Aug 20, 2021

@hugovk silly me. Added.

nateprewitt
nateprewitt approved these changes Sep 24, 2021
View reviewed changes
Copy link
Contributor

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @D3X!

@nateprewitt nateprewitt merged commit 485029e into boto:develop Sep 24, 2021
@D3X D3X deleted the python-3.9 branch September 24, 2021 17:22
aws-sdk-python-automation added a commit that referenced this pull request Sep 24, 2021
@aws-sdk-python-automation
Merge branch 'release-1.18.48'
fb82bde 
* release-1.18.48:
  Bumping version to 1.18.48
  Add changelog entries from botocore
  Declare support for Python 3.9 (#2942)
  Convert functional tests to pytest
  Convert unit tests to pytest
  Update tests for Pytest support
  use pytest instead of nose
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nateprewitt nateprewitt nateprewitt approved these changes

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@D3X @hugovk @nateprewitt